Repository navigation
CheckpointManager: constructors/methods that take BitcoinNetwork rather than NetworkParameters - #4357
Open
msgilligan wants to merge 1 commit into
Open
msgilligan wants to merge 1 commit into
msgilligan wants to merge 1 commit into
Conversation
msgilligan
marked this pull request as draft
August 27, 2026 22:19
msgilligan
changed the title
msgilligan
force-pushed
the
msgilligan/CheckpoinManager-prefer-Network
branch
from
August 28, 2026 14:14
e1a6217 to
01a0e87
Compare
msgilligan
changed the title
msgilligan
marked this pull request as ready for review
August 28, 2026 17:43
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will need a rebase and finishing after several other recent PRs have been merged.
After this is merged, we should be able to update
WalletToolto remove all dependencies onNetworkParameters!