Repository navigation
FullBlockTestGenerator, BitcoindComparisonTool, FullPrunedBlockChainTest cleanup/modernization - #4350
Open
msgilligan wants to merge 7 commits into
Conversation
Make most fields final. Fields that cannot be made final without other changes are left mutable.
For readability, parse the port argument right after the runExpensiveTests argument.
…local var Prior to this commit in each class, the FullBlockTestGenerator is constructed and used for a single getBlocksToTest() leaving the local variable `generator` unused after that. To make the code more readable we simply call getBlocksToTest() on the instance and save the resulting RuleList in a local variable.
msgilligan
force-pushed
the
msgilligan/FullBlockTestGenerator-make-fields-final
branch
from
August 30, 2026 03:24
5117175 to
a3c1b3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.