Skip to content

FullBlockTestGenerator, BitcoindComparisonTool, FullPrunedBlockChainTest cleanup/modernization - #4350

Open
msgilligan wants to merge 7 commits into
bitcoinj:masterfrom
msgilligan:msgilligan/FullBlockTestGenerator-make-fields-final
Open

msgilligan wants to merge 7 commits into
bitcoinj:masterfrom
msgilligan:msgilligan/FullBlockTestGenerator-make-fields-final

Conversation

@msgilligan

Copy link
Copy Markdown
Member

No description provided.

@msgilligan msgilligan changed the title FullBlockTestGenerator, BitcoindComparisonTool, FullPrunedBlockChainTest cleanup/modernizatio FullBlockTestGenerator, BitcoindComparisonTool, FullPrunedBlockChainTest cleanup/modernization Aug 27, 2026
@msgilligan
msgilligan requested a review from schildbach August 27, 2026 15:56
@msgilligan msgilligan added this to the 0.18 milestone Aug 27, 2026
Make most fields final. Fields that cannot be made final without
other changes are left mutable.
For readability, parse the port argument right after the runExpensiveTests
argument.
…local var

Prior to this commit in each class, the FullBlockTestGenerator is constructed and
used for a single getBlocksToTest() leaving the local variable `generator`
unused after that. To make the code more readable we simply call getBlocksToTest()
on the instance and save the resulting RuleList in a local variable.
@msgilligan
msgilligan force-pushed the msgilligan/FullBlockTestGenerator-make-fields-final branch from 5117175 to a3c1b3c Compare August 30, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant