Do not pin the status an absent file returns - #1154
Merged
Merged
Conversation
files.wwpdb.org moved behind Amazon S3, which answers a missing key with 403 rather than 404 when the caller cannot list the bucket. The test asserted 404 and has failed the nightly since 2 September, hiding every later module. It now asserts the contract - an error status throws and nothing is written - and isNotFound() is pinned separately without a network. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_011NUW9k3A19Ee3MYMU7v7EV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
files.wwpdb.orgnow sits behind Amazon S3, which answers a missing key with 403 rather than 404 when the caller cannot list the bucket:notFoundThrowsAndLeavesNothingBehindasserted 404, so it has failed every nightly since 2 September. Because it is inbiojava-core, the other thirteen modules are skipped — includingbiojava-integrationtest, so the ECOD failure behind it (#1149) is invisible.Nothing is broken: real files still return 200 with
Content-Length,Last-Modified,ETagandAccept-Rangesintact, the same MD5 as before.The test now asserts the contract rather than the status code — an error status throws, nothing is written, no
.sizesidecar — andisNotFound()gets its own offline test, since 404/410 versus 403/500 decides whether the download fallback chain continues or aborts.🤖 Generated with Claude Code