Repository navigation
docs(mcp-builder): make evaluation command examples runnable - #1921
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
|
Reviewed at head Scope: The failure is real at the parent — every Bash block containing
Fix verified (head)
Notes (non-blocking):
No remaining findings at |
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Four of the six command examples in
skills/mcp-builder/reference/evaluation.mdfail before evaluation starts. Argparse options-a,-e, and-Haccept one or more values, so when an example putsevaluation.xmlafter the final such option, argparse consumes it and reports the requiredeval_fileis missing. The repeated-eand-Hspellings also drop earlier values on current main (tracked separately by #1896).Change
Put the XML positional argument first in every example and group multiple environment variables or headers under one flag. Add a short rule explaining the order.
Verification
I extracted all six Bash examples and parsed them with the script's current argparse declarations. On main, four failed with
the following arguments are required: eval_file; after this edit, all six parse, and the multi-value examples retain both environment variables and both headers.git diff --checkpasses.