Repository navigation
fix(docx): use platform temp dir and stop claiming success on timeout in accept_changes.py - #1848
Closed
TINGyu123644 wants to merge 1 commit into
Closed
TINGyu123644 wants to merge 1 commit into
TINGyu123644 wants to merge 1 commit into
Conversation
… in accept_changes.py
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two real defects in
accept_changes.py:LIBREOFFICE_PROFILE = "/tmp/libreoffice_docx_profile"is a hard-coded Unix path. On Windows (which this repo's office scripts explicitly support elsewhere)/tmpdoes not exist, so LibreOffice cannot create its user profile and the macro never runs. Use the platform temp dir instead.TimeoutExpiredfromsubprocess.run(..., timeout=30)is reported as "Successfully accepted all tracked changes", even though the file was only copied and never processed. Report a timeout honestly instead of claiming success.Verified:
python -m py_compilepasses.