Skip to content

fix(skill-creator): keep scanning trigger events - #1766

Closed
00200200 wants to merge 1 commit into
anthropics:mainfrom
00200200:fix/skill-trigger-eval-streams
Closed

00200200 wants to merge 1 commit into
anthropics:mainfrom
00200200:fix/skill-trigger-eval-streams

Conversation

@00200200

Copy link
Copy Markdown

Summary

  • keep scanning stream events when another tool appears before Skill or Read
  • continue after an unrelated tool block instead of treating it as a failed trigger
  • inspect every tool use in a fallback assistant message before deciding

Fixes #1721

Validation

I ran python3 -m py_compile and exercised run_single_query() with a fake Claude CLI covering:

  • another tool before the matching Skill call
  • an unrelated Skill block followed by the matching one
  • a fallback assistant message containing multiple tool uses

All three cases detected the skill trigger. git diff --check passes.

AI assistance disclosure

This PR was prepared with assistance from OpenAI Codex. I reviewed the implementation and validation results and understand the change.

@98zc5g5jyw-arch

Copy link
Copy Markdown

Flagging a collision risk before this grows further: skills/skill-creator/scripts/run_eval.py trigger detection is being edited by four open PRs from the same base (e58c70bea3):

Your patch at L138+ fixes the same short-circuit behavior #1757 addresses with a more complete state machine, and the hunks will conflict. Suggest coordinating with #1757's author (either fold this into it or rebase on top once one of them merges). Thanks!

@00200200
00200200 force-pushed the fix/skill-trigger-eval-streams branch from 6b61d58 to feb182a Compare September 14, 2026 14:53
@00200200

Copy link
Copy Markdown
Author

Closing this smaller overlapping patch in favor of #1757, which addresses the same trigger-scanning defect with the complete state-machine implementation and dedicated tests. Thanks for pointing out the collision.

@00200200 00200200 closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

skill-creator: trigger detection reports 0% recall for every skill

2 participants