Repository navigation
Conversation
Babysit review — LGTM ✅Four retired model IDs moved to retired with correct retirement dates and successor models ( |
98zc5g5jyw-arch
left a comment
There was a problem hiding this comment.
Hermes Review
Verdict: Comment — correct and useful model-status update; two cross-file consistency nits.
Verified
- Moving the four models (opus-4, sonnet-4, haiku-3, opus-4.1) to "Retired" is consistent with their retirement windows having passed (all ≤ Aug 2026 vs. repo's reference date).
- The effort/alias guidance updates are consistent within
models.md.
Warnings
- Retirement date drift within the PR: the removed "Deprecated" table in
model-migration.mdlistedclaude-3-haiku-20240307retiring Apr 19, 2026, but the new "Retired" rows say Apr 20, 2026.models.mdin the same PR says Apr 20. If Apr 20 is the correct canonical date, fine — but call it out, since the change is silently different from what the repo previously documented. claude-opus-4-1missing frommodel-migration.md:models.mdnow listsclaude-opus-4-1-20250805as Retired (Aug 5, 2026), butmodel-migration.md's retired table is not updated with it. The two files will disagree.
Suggestions
- Add
claude-opus-4-1-20250805→claude-opus-4-8(or opus-5, per the alias table) tomodel-migration.md's retired table, and reconcile the haiku-3 date in one place.
Reviewed by Hermes Agent (cron babysitter)
|
Thanks for the review @98zc5g5jyw-arch! Added |
98zc5g5jyw-arch
left a comment
There was a problem hiding this comment.
Re-review after bdff74f: cross-file consistency nits addressed — claude-opus-4-1-20250805 added to retired model table with drop-in replacement, Haiku 3 retirement date aligned (Apr 19) across model-migration.md and models.md. LGTM.
|
Hi @98zc5g5jyw-arch, just checking if everything looks good to land this PR, or if any additional adjustments are needed. |
bdff74f to
dd93cab
Compare
|
Small date correction: Anthropic's official model deprecations page lists https://platform.claude.com/docs/en/about-claude/model-deprecations |
|
Reviewed at the follow-up head Both follow-ups from your replies are in place at this head: Verified at
One correction (same as @GBX-Max1220's note; verified against the page):
Your PR body already states "retired Apr 20, 2026" — these two table rows are the only places still on Apr 19. (My earlier review said "correct retirement dates" while that row was already reconciled to Apr 19 — the off-by-one slipped through on my side; Apr 20 is the official date.) Non-blocking: |
# Conflicts: # skills/claude-api/shared/model-migration.md # skills/claude-api/shared/models.md
|
Thanks @GBX-Max1220. I checked the model deprecations page and you are right. I also merged upstream main (dd66d1c). Main now lists newer default models, so bf5eddf sets the suggested replacements for the newly retired IDs to the ones the deprecations page recommends. Those are |
|
Follow-up re-review at head Delta since Verified at
Non-blocking observation
LGTM from my side; the two earlier items are fully addressed. |
|
Closing this. The four model IDs stay retired upstream, and keeping the PR open is not worth the noise. |
Update claude-api skill: mark four retired model IDs as retired
Fixes #1603
What was wrong
skills/claude-api/shared/models.mdstill listedclaude-opus-4-1under "Legacy Models (still active)" andclaude-sonnet-4-0,claude-opus-4-0, andclaude-3-haiku-20240307under "Deprecated Models (retiring soon)". All four IDs return 404 from the Messages API, and each retirement date on the official Model deprecations page has already passed:claude-opus-4-1-20250805: retired Aug 5, 2026claude-opus-4-20250514: retired June 15, 2026claude-sonnet-4-20250514: retired June 15, 2026claude-3-haiku-20240307: retired Apr 20, 2026The file explicitly tells the reader to trust these IDs over their own knowledge, so the stale rows were recommending models that fail on first use.
What changed
models.mdwith their official retirement dates.models.mdandmodel-migration.md.model-migration.mdinto the "Retired Model Replacements" table.models.mdfrom "deprecated" to "Retired — suggest ..." so the suggested replacements stay reachable.Verification
platform.claude.com/docs/en/about-claude/model-deprecations).I could not call the Messages API directly from my environment because no
ANTHROPIC_API_KEYis set, so the 404 claims come from the issue reproduction and the official deprecations page rather than a live curl.