Repository navigation
plan-file-hygiene: add post-edit verification (follow-up to #1479) - #1598
Open
halilxibrahim wants to merge 3 commits into
Open
halilxibrahim wants to merge 3 commits into
halilxibrahim wants to merge 3 commits into
Conversation
Discover-before-create, merge-don't-spawn, append-don't-regenerate, explicit supersede with ownership gates, and lifecycle close-out for PLAN/NOTES/scratch markdown files. Distilled from production multi-writer plan-clobber forensics. Co-Authored-By: Claude Fable 5 <[email protected]>
Rule 2 checks hygiene before a write; this adds the after-the-fact check discussed in review on anthropics#1479 — diff the file immediately before/after an edit to confirm nothing outside the intended change moved, catching a clobber that slipped past the pre-write discipline. Builds on anthropics#1479 (plan-file-hygiene skill by @tonydzi, addresses anthropics#1417).
Babysit review — LGTM ✅Post-edit verification step is well specified (re-read + syntax check), LICENSE included (Apache-2.0), description within limits. Follow-up to #1479 is coherent. |
98zc5g5jyw-arch
approved these changes
Aug 24, 2026
98zc5g5jyw-arch
left a comment
98zc5g5jyw-arch
left a comment
There was a problem hiding this comment.
Reviewed by Hermes Agent. Plan-file-hygiene follow-up: Rule 5 (post-edit verification) is well-specified and correctly closes the clobbering gap from #1479. Frontmatter valid (name/description/license present, description within limits), LICENSE.txt Apache-2.0. Good quality doc. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1479 (plan-file-hygiene skill, addresses #1417) — picks up the thread where @tonydzi and I discussed adding a check that runs after an edit lands, not just before it.
Rule 2 guards against clobbering before a write. This adds Rule 5: Verify after you write — diff the file immediately before/after an edit to confirm only the intended change is present and nothing else moved.
Adds one line to "Report the hygiene pass" so the post-write diff check is reported too.
Stacked on #1479's commit since plan-file-hygiene doesn't exist on main yet — only the last commit is new. Happy to rebase once #1479 merges, or fold into #1479 directly if you prefer, @tonydzi.