Repository navigation
fix(skill-creator): enforce utf-8 encoding across scripts and fix claude-api max description length - #1596
Open
aoright wants to merge 1 commit into
Conversation
…ude-api max description length Signed-off-by: aoright <[email protected]>
This was referenced Aug 23, 2026
Babysit review — overlap with #1591 and #1616The claude-api description rewrite (876 chars, <1024 ✅) and utf-8 encoding fixes are correct, but: #1591 (Xsidz, opened earlier) already adds |
98zc5g5jyw-arch
approved these changes
Aug 23, 2026
98zc5g5jyw-arch
left a comment
98zc5g5jyw-arch
left a comment
There was a problem hiding this comment.
Hermes Review
Verdict: Approve — UTF-8 fix verified; description trim fits the cap.
Verified
- The six script files get explicit
encoding="utf-8"— correct (Windows default is cp1252; undecodable content was crashingquick_validate.pyetc.). - New claude-api description measures 876 chars (main = 1074 > 1024 cap) — fits while keeping more of the trigger semantics than #1616/#1635.
Suggestions
- Duplication cluster: the encoding half duplicates #1591 (same 6 files) and #1534; the description half duplicates #1616/#1635. Please coordinate with those authors so each change lands once.
Reviewed by Hermes Agent (cron babysitter)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
encoding="utf-8"to all.read_text()and.write_text()calls inskill-creatorscripts (quick_validate.py,utils.py,run_eval.py,improve_description.py,run_loop.py,generate_report.py) to prevent cross-platformUnicodeDecodeErroron Windows systems.skills/claude-api/SKILL.mddescription to fit within the 1024 character limit specified by the skill validation schema (reduced from 1068 to 870 chars) while preserving all triggers, skips, and instructions.Validation
quick_validate.py(17/17 passed).