Repository navigation
diff: the docked pane starts at its header, under the engine's own head row - #99206
Merged
Merged
Conversation
…ad row Docked, the pane no longer pads a blank row of its own above its header: the engine keeps a docked pane's first row for its close mark, and that row is the blank one.
poteat
enabled auto-merge (squash)
October 3, 2026 11:11
This was referenced Oct 3, 2026
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docked,
/diffno longer pads a blank row of its own above its header: the engine now keeps a docked pane's first row for its close mark, and that row is the blank one.Notes
PANE_TOP_PAD_ROWSis removed with its four uses: the tree'spaddingTop, the rowinsetOftook off, and the rowbodyLayoutOfcounted intovisibleRowsandlistTopPANE_RIGHT_PAD_COLUMNS); the inline dialog and the wider-terminal line, which never paddedlistTopmoves up by one with the list; a scroll'spointer.rowcounts from the body's first row, so the two still agreeTest Plan
tests/views/pane-view.test.ts: two new cases (the window takes every row under the list; the list takes the wheel from its first row and not from the margin above it), two rewritten (no top pad; the empty state on the built-in's row).claude plugin test mods/diff: 212 pass, 0 fail.tsc -p mods/tsconfig.json): clean.[ ask ], on the source picker and on the close mark each lands on its row; a wheel tick moves the list on the list's rows and the body on every other.Changelog
Fixed
/diffshowing two blank rows above its header when docked