diff --git a/mods/diff/README.md b/mods/diff/README.md index 9340542248..b221a113e5 100644 --- a/mods/diff/README.md +++ b/mods/diff/README.md @@ -37,8 +37,8 @@ where the focus ring starts; the plugin follows the ring's walk through `ui.focus` and re-centres the rows as the built-in does), the key hints; Enter shows that file's hunks alone, Escape backs out to the list and then closes, leaving `Diff dialog -dismissed`; toasts are held while it is up. A file's ask button arms that -file: its hunks ride the next prompt as context, once. +dismissed`; toasts show while it is up, as beside the docked pane. A file's +ask button arms that file: its hunks ride the next prompt as context, once. The pane compares the working tree against HEAD, split at the session's start (the default; the start the engine gives in `$.session.usage()`, so a diff --git a/mods/diff/hooks/register.ts b/mods/diff/hooks/register.ts index 3273ad0a36..519d17f574 100644 --- a/mods/diff/hooks/register.ts +++ b/mods/diff/hooks/register.ts @@ -180,7 +180,6 @@ export function register(on: On) { return { id: Names.PANE_ID, title: Names.PANE_TITLE, - holdToasts: true, closeOnEscape: true, rows: Views.dialogRowsOf(model), } @@ -439,7 +438,7 @@ export function register(on: On) { const opened = await engine.openPane( isDialog ? { ...dialogPane(), focus: true } - : { id: Names.PANE_ID, title: Names.PANE_TITLE, holdToasts: true }, + : { id: Names.PANE_ID, title: Names.PANE_TITLE }, ) const isWaiting = isRecord(opened) && opened.isPlaced === false diff --git a/mods/diff/tests/register.test.ts b/mods/diff/tests/register.test.ts index 124f6d84ee..65ab8de379 100644 --- a/mods/diff/tests/register.test.ts +++ b/mods/diff/tests/register.test.ts @@ -358,9 +358,7 @@ describe('register', () => { '--show-toplevel', ) - expect(world.opened).toEqual([ - { id: 'diff', title: 'Diff', holdToasts: true }, - ]) + expect(world.opened).toEqual([{ id: 'diff', title: 'Diff' }]) await world.clock.advance(Fixtures.SETTLE_MS) @@ -380,7 +378,6 @@ describe('register', () => { expect(world.opened[0]).toEqual({ id: 'diff', title: 'Diff', - holdToasts: true, closeOnEscape: true, rows: expect.any(Number), focus: true, diff --git a/mods/diff/tests/views.test.ts b/mods/diff/tests/views.test.ts index 1ba8ad485d..b07b606215 100644 --- a/mods/diff/tests/views.test.ts +++ b/mods/diff/tests/views.test.ts @@ -290,7 +290,6 @@ describe('views', () => { expect(world.opened.at(-1), 'sized to its rows once listed').toEqual({ id: 'diff', title: 'Diff', - holdToasts: true, closeOnEscape: true, rows: 8, })