Repository navigation
Conversation
The pane and the dialog were opened with holdToasts, which holds every toast while the pane is shown: other plugins' and the app's own, as this plugin's. Nothing in the mod relies on the hold, and a toast no longer lands between the pane and the prompt, so the option goes from both opens.
poteat
enabled auto-merge (squash)
October 3, 2026 01:36
5 tasks done
This was referenced Oct 3, 2026
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
/diffopened its pane and its dialog withholdToasts: true. That option holds every transient toast while the pane is the one shown: each other plugin's$.ui.toastand the app's own, not only this plugin's. A plugin that toasts on a timer showed nothing for as long as/diffwas open, and its toasts came out in a burst on close.Test Plan
claude plugin test mods/diffpasses: 210 pass, 0 fail/diffopen for 7 s: toasts show throughout, docked and in the dialog/diffis open, and the held ones burst out on closeChangelog
Fixed other plugins' toasts staying hidden while the
/diffpane was open