Repository navigation
Conversation
stephanien-ant
approved these changes
Sep 27, 2026
notitatall
approved these changes
Sep 27, 2026
…nd and reads the entry as the telemetry types give it
This was referenced Sep 27, 2026
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
telemetry.logfor the collector's stream now continues past the user tier, asclassic.*andsettings.readdo. The organization's ownprependandappendplugins still may hook it.Notes
The row is one line in
hooks/register.ts:on('telemetry.log', { to: 'collector' }, ($, e, next) => next.to(e, 'append')). The matcher is the literal stream, so theanthropicstream is not touched.Inert in a CLI whose own event records do not travel this event: there the row meets only what a plugin logs through
$.telemetry.log. It takes effect with the release that routes the CLI's own collector records throughtelemetry.log, and merges after that release.Test Plan
mods/sec-default/tests/register.test.ts: the new case "a collector record passes over the plugins the person installed" loads a user-tier plugin that denies one record and marks every other oneedited, logs two records, and expects both to arrive as logged; with the row taken out, that case is the one that fails