Repository navigation
Conversation
…r; the declarations carry session.append
This was referenced Sep 26, 2026
|
Not stamping this one yet. Three things:
I'll stamp it after a rebase. |
3 tasks
5 of 6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order: after the engine has
session.appendon main AND no live engine release branch lacks it (the engine's build links this mod; the name does not scan on an engine without the event).The
testcheck is red by construction until a released CLI carries the event, not by accident. This repository's CI installs the released CLI from npm and runs each mod's suite with it; on a CLI withoutsession.appendthe scan refuses this mod's hooks module ("session.append" is not an event), so sec-default's suite fails there while agents-md, diff and telemetry pass. It turns green on its own with the first release that carries the event, and this merges only after that release is the one CI installs, so thatmain's CI never goes red for the pull requests that follow.sec-default:
session.append, the event raised once for each row a conversation keeps (a prompt, a tool result, a settings hook's context, a reminder) whose hooks may rewrite what is stored and sent from then on, joins the rows that continue past the user tier (next.to(e, "append")), besideprompt.sectionandprompt.context. Where an organization seats sec-default, the rows are kept as the organization's tiers and the built-ins left them; everywhere else a person's plugin hooks the event like any other.mods/sec-default/hooks/register.ts: one line, the mirror of theprompt.sectionone.mods/sec-default/tests/register.test.ts: one case beside theprompt.sectionone. A plugin the person installed rewords a settings hook's context row; it is passed over, and the organization's append-tier plugin and what is beneath it stand.mods/sec-default/README.md: a row for the event, the list of hooked events names it, and the rows that pass saysession.*other thansession.append.mods/types/claude-code.d.ts: the declarations carrysession.append(its input, message, door, origin and result types, the content block type they use, and$.session.appendon the test kit's engine).Checked:
tsc -p mods/tsconfig.jsonis clean against the declarations in this branch.prompt.sectioncase and is to be run, with and without the new line, on the first build that carries the event before this merges.