Repository navigation
Conversation
…entries' mtimeMs; the test fakes answer them
This was referenced Sep 25, 2026
bhosmer-ant
approved these changes
Sep 29, 2026
bhosmer-ant
left a comment
There was a problem hiding this comment.
Declarations and fixtures match what the CLI generates, line for line. Nothing reads the new fields yet.
This was referenced Sep 29, 2026
|
Rebased onto main, this needs three more additions, or Patch against main |
5 of 6 tasks
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arm when the released npm CLI carries both fields (
isStdoutTruncated/isStderrTruncatedon a$.process.runresult,mtimeMson a$.fs.listentry): until then these declarations would promise what the installed CLI does not answer yet.The engine's
$.process.runresult now says, per stream, whether its output was cut at the limit (isStdoutTruncated,isStderrTruncated), and its declaration states that limit as a number: 4194304 bytes each. A$.fs.listentry now carriesmtimeMs: a regular file's own, as$.fs.statspells it, and 0 for a directory, a link or any other kind, assizeis.The declarations in
mods/typesfollow (theProcessRunResultandFsEntrytypes, and therunandlistdocs), and every test fake that builds one of those values answers the new fields: the scripted git results andgitIninmods/diff/tests, the telemetry probe and listing fixtures, the README's example test, and the recording backend host, whose runner hands on the mod's own narrower run result and so fills the two flags in. No mod reads the new fields yet; the diff mod's own output-cap arithmetic can move toisStdoutTruncatedin a later change.Checked:
tsc -p mods/tsconfig.jsonpasses at this branch's head. It checks against the declarations in this folder, so the change is consistent on its own; without the fixture edits it fails once in each of the ten fixture files.claude plugin test mods/diffandclaude plugin test mods/telemetryare unchanged by them.