Repository navigation
telemetry: log and mark are what the mod's hooks do, the noun added only where the engine has none - #96917
Merged
Conversation
…nly where the engine has none
…telemetry it already has stands
notitatall
approved these changes
Sep 25, 2026
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
$.telemetry.logand$.telemetry.markdo was the two methods of the noun the mod adds in theengine.createfold. It now lives in two hooks on the noun's events,telemetry.logandtelemetry.mark, beneath the gate: each checks the entry, queues its row and answers{ value }; an entry that breaks a rule is answered{ deny }with the reason, so the caller's promise still rejects, its text ending$.telemetry.log: <reason>as before. The rows, the batching, the gate and what is sent are unchanged.This lets the same mod run on an engine that provides
$.telemetryitself: theengine.createstep hands up what it was given, untouched, when that already has atelemetry, and adds the noun, as before, only where there is none. A log entry may name where it goes withto:anthropic, the default, is this mod's, and an entry forcollectoris passed on beneath.tois never part of a row.types/index.d.tsgainsTelemetryDestinationand the optionalto; the README says what the mod hooks now.Checked:
mods/telemetry/tests/register.test.ts: a new case, "a refused entry is denied by the hook, naming the caller and the reason", pins the rejection's exact text forlogand formark.mods/telemetry/tests/gate.test.ts: two new cases, each with a plugin whose one hook is on every event: one turns a row'stoto the other destination, one adds a key beside the entry's fields. Either way the row goes out once and equals the expected row.claude plugin test mods/telemetrypasses 34 of 34; the other mods' suites are unchanged and green. With these tests run over main's hooks, the exact-text case is the one that fails.