Repository navigation
diff: the command.run hook names its command by a literal the engine's scan reads - #96570
Merged
Merged
Conversation
poteat
enabled auto-merge (squash)
September 24, 2026 02:55
notitatall
approved these changes
Sep 24, 2026
This was referenced Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mod's
command.runhook matched its own command through a named constant ({ command: Names.COMMAND_NAME }). The engine's scan of a hooks module reads literal command names incommand.runmatchers, and uses them to decide which slash commands typed right at startup must wait for a module that is still loading. A constant it cannot read counts as "may hook any command", so while the diff mod was loading every early listed command (/help,/exit, ...) waited for it.The matcher now spells the literal,
{ command: 'diff' }, the way the mod'sclear/resumehook already does. Behaviour is unchanged (the constant's value is'diff');claude plugin validate mods/diffnow reportscommand.run{command=diff}.Checked:
claude plugin validate mods/diffpasses and lists the hook ascommand.run{command=diff}./helptyped while a mod with a 3 s start loads opens in 4.5 to 4.9 s with this line and 8.2 s without it.