Repository navigation
telemetry: complete rows gathered through $, sent in batches, serving built-in plugins only - #95618
Merged
Merged
Conversation
… built-in plugins only
bhosmer-ant
approved these changes
Sep 20, 2026
bhosmer-ant
reviewed
Sep 20, 2026
bhosmer-ant
left a comment
There was a problem hiding this comment.
Stamped. One question: isInternal, which decides whether the user's email goes into the row, reads $.env.get('USER_TYPE'). If the engine answers that from process.env rather than the build-time define, an external user who sets USER_TYPE=ant would have their email collected. Worth confirming it resolves from the define. Not a blocker.
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The telemetry mod now runs wherever Claude Code's analytics are on, for the plugins built into Claude Code: a hook on its own two events reads who raised the call (
next.origin) and refuses a plugin a person installed or an administrator listed, with a reason. Its rows carry what the CLI's own rows carry, gathered through$once a session (device and account ids from the CLI's config, client type, entrypoint, theenvblock); what only the engine knows (its version, build time, runtime) is not on$and stays empty. Rows are queued and sent in batches (a few seconds after the first, at a hundred, and at session end) with one retry;logandmarkresolve once queued. It honours every analytics opt-out the CLI honours, re-read before each batch, and sends nothing when they cannot be read. On an engine that hands out no first-party credential it sends nothing, as before. Tests beside the mod.