Repository navigation
mods/diff: type openPane's answer as unknown so a richer $.ui.open result compiles - #95198
Merged
Merged
Conversation
poteat
enabled auto-merge (squash)
September 17, 2026 17:02
konsta95
approved these changes
Sep 18, 2026
konsta95
left a comment
konsta95
left a comment
There was a problem hiding this comment.
Verified locally at 38f6d7c against base 68ac8bb:
tsc -p mods/tsconfig.json(5.9.3) passes on base and head.- With
$.ui.openretyped to resolve an object, base fails at
register.ts:609 and head compiles. - All three
openPanecall sites discard the value. - Emitted JS for host.ts and register.ts is byte-identical.
- diff mod tests: 142/142 on base and head, on 2.1.274 and 2.1.276.
On 2.1.276 $.ui.open still resolves undefined under
plugin test, so this lands ahead of the engine change.
notitatall
approved these changes
Sep 18, 2026
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The diff mod's host contract declared
openPaneas returningPromise<void>.$.ui.openis about to resolve with a small result object, so the declared type becomesPromise<unknown>, which compiles against both the current and the next engine typings. No caller reads the value; behaviour is unchanged.