Repository navigation
fix(pr-review-toolkit): repair invalid YAML frontmatter in all agents - #87077
Open
anishsamant wants to merge 1 commit into
Open
anishsamant wants to merge 1 commit into
anishsamant wants to merge 1 commit into
Conversation
Every agent's description was a single unquoted scalar containing dialogue lines like Daisy: "..." / Assistant: "...", which YAML parses as an illegal nested mapping. That leaves the agent loading with empty frontmatter (name/description/model/color all silently dropped), so it can't be selected by description-based routing. silent-failure-hunter.md was reported (anthropics#86748); the same defect was present in the other five agents in this plugin, so all six are converted to a `description: |` block scalar. Body content and description text are unchanged, only the frontmatter encoding. Fixes anthropics#86748 Co-Authored-By: Claude Sonnet 5 <[email protected]>
|
This overlaps #91871, which measured the same class against the actual loader ( |
|
Applications of the sample is not given |
5 of 6 tasks
|
This looks like a helpful fix. I’m new to YAML frontmatter, but using the literal block seems like a good approach for handling the dialogue examples without having to escape all the quotes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every agent's description was a single unquoted scalar containing dialogue lines like Daisy: "..." / Assistant: "...". In YAML,
key: valueinside an unquoted scalar is parsed as a nested mapping, which is invalid in that position — so the agent loads withempty frontmatter (name/description/model/color all silently dropped) and can't be selected by description-based routing.
silent-failure-hunter.md was reported (#86748); the same defect was present in the other five agents in this plugin, so all six are converted to a
description: |literal block scalar. A block scalar was used instead of quoting so the embedded double quotes in the dialogue examples don't need escaping.Body content and description text are otherwise unchanged — only the frontmatter encoding.
Verified
yaml.safe_load(previously all 6 failed)values is empty)
Fixes #86748