You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(plugin): resolve local package manifest entrypoints - #53796
Addresses #52300 (local package-directory manifest entrypoint discovery). Direct file-path configuration is unchanged; that separate part of the issue is not claimed fixed.
Type of change
Bug fix
New feature
Refactor / code improvement
Documentation
What does this PR do?
Resolve local plugin directories through their package manifest before asking the runtime to resolve the resulting entrypoint. Packages using main: dist/index.js or conditional exports then load when configured by their directory.
Use [email protected] for conditional maps. Respect deliberately unexported server/TUI/RPC files, reread manifests during reload, and retain the configuration layer's real-path containment checks. No API contract changes or generated client edits.
How did you verify your code works?
Prior verification for candidate 5e7a5194045ed39589779bd8a7160dadb18cb071, baseline 5183ea45c39aaabf14236d0ce8ae0b086d9c31e8:
bun run check: all 36 tasks passed in a bounded 10 GiB scope.
Plugin package tests: 14 passed.
Focused core supervisor reload/containment tests passed through the package's isolated test runner.
Built the single-platform CLI with --skip-install --skip-web-ui. Independently packed/installed Claude and Jev plugins loaded directly from their package directories and passed direct/routed shared-backend streaming, concurrent-project reload and real read-tool continuation fixtures.
These are the original candidate's offline receipts, not current-live-target hosted acceptance. Current full-candidate Codex review and required application CI remain outstanding. Actual subscription inference is outside the offline tests. No local tests or builds were run during this maintenance pass.
Screenshots / recordings
Not applicable: package loading change with no UI changes.
Please review the complete PR candidate at head 5e7a5194045ed39589779bd8a7160dadb18cb071 against current v293afa91904022f3f6849ada78918407fe90e795d, including all still-actionable historical findings. This is a full-candidate code review request, not a security-only review.
Please review the complete candidate 5e7a5194045ed39589779bd8a7160dadb18cb071 against current v2434f7b2a3670dd932794688bee5e34029e546630, including historical findings. This is full-candidate code review, not security-only. Both candidates apply without conflicts to this live target; required application CI and maintainer approval remain separate gates.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Addresses #52300 (local package-directory manifest entrypoint discovery). Direct file-path configuration is unchanged; that separate part of the issue is not claimed fixed.
Type of change
What does this PR do?
Resolve local plugin directories through their package manifest before asking the runtime to resolve the resulting entrypoint. Packages using
main: dist/index.jsor conditionalexportsthen load when configured by their directory.Use
[email protected]for conditional maps. Respect deliberately unexported server/TUI/RPC files, reread manifests during reload, and retain the configuration layer's real-path containment checks. No API contract changes or generated client edits.How did you verify your code works?
Prior verification for candidate
5e7a5194045ed39589779bd8a7160dadb18cb071, baseline5183ea45c39aaabf14236d0ce8ae0b086d9c31e8:bun run check: all 36 tasks passed in a bounded 10 GiB scope.--skip-install --skip-web-ui. Independently packed/installed Claude and Jev plugins loaded directly from their package directories and passed direct/routed shared-backend streaming, concurrent-project reload and real read-tool continuation fixtures.These are the original candidate's offline receipts, not current-live-target hosted acceptance. Current full-candidate Codex review and required application CI remain outstanding. Actual subscription inference is outside the offline tests. No local tests or builds were run during this maintenance pass.
Screenshots / recordings
Not applicable: package loading change with no UI changes.
Checklist