Repository navigation
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
|
The @rekram1-node, could you review this OpenAI provider fix when you have a chance, and help link #47646/remove the incorrect label? I chose you based on your recent changes in this provider. The production change removes the two-line blanket limit override; regression coverage checks long-context models, a fast alias, and a smaller-context model. The regression failed before the fix and passes afterward; the focused suite, core typecheck, and full |
Drop the blanket 400K/272K override for gpt-5.5/5.6 OAuth models so long-context models keep catalog limits instead of compacting prematurely, and smaller-context models are not inflated. Upstream: anomalyco#53080
|
Additional runtime verification on PR head dc65500: built the Linux x64 CLI with Bun 1.4.2 and ran its private server with a ChatGPT OAuth connection. After catalog initialization, This verifies the effective metadata in the compiled server; it does not claim a million-token inference test. |
|
Could a maintainer triage this for an OpenAI provider review, clear the false-positive The key review question is whether ChatGPT OAuth should preserve model catalog limits instead of imposing the Codex CLI budget. #44821 reports a controlled GPT-5.6 Sol request accepting 921,858 input tokens through OAuth—evidence that the blanket 272K input cap is too low for that account/route, though not proof of identical capacity for every account. This PR preserves each model’s existing limits rather than introducing another universal limit. If maintainers require account-specific limit discovery or an opt-in approach instead, guidance on that decision would help move the fix forward. |
Issue for this PR
Fixes #47646
Type of change
What does this PR do?
Preserves model-specific context and input limits when connected through ChatGPT OAuth, removing the blanket 400K/272K override. Long-context models retain their catalog limits instead of reporting inflated context usage and compacting prematurely.
Updates the provider regression test to cover long-context models, a fast alias, and a smaller-context model.
How did you verify your code works?
bun run test test/plugin/provider-openai.test.tsinpackages/core: 5 passed.bun typecheckinpackages/core: passed.bun run check: passed (lint warnings, no errors; 36 typecheck tasks succeeded).Screenshots / recordings
N/A
Checklist