Repository navigation
fix(tui): keep question form highlights on the raised surface - #52872
Merged
Merged
Conversation
jlongster
force-pushed
the
fix-selection-bg
branch
from
October 3, 2026 00:28
1357cba to
80bf487
Compare
Ichinose-Kazuki
pushed a commit
to Ichinose-Kazuki/opencode
that referenced
this pull request
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the question form, the focused option and the selected/hovered tab draw a darker strip behind their text that doesn't match the raised panel around them.
Cause
#49661 replaced
useTheme("elevated")with the base theme and swappedbackground.defaultforbackground.raised.basein the form. The highlighted states still usedbackground.formfield.focused/selected, which alias$background.base. Under the old elevated theme that alias resolved to the elevated background, so it was invisible. Now it resolves to the base background, which is darker than the raised panel.Fix
Use
background.raised.basefor those rows and tabs. This restores the look from before #49661: focus and the active tab are shown by text color and weight, not a background chip.Screenshots
Focused option
Tabs (multiple questions)