Repository navigation
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This was referenced Oct 3, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #53649
Also the session-switch half of #39181. The directory-scoping half of that issue isn't touched here.
Type of change
What does this PR do?
POST /tui/select-sessionnavigates every TUI attached to the server, because thetui.session.selecthandler inapp.tsxonly checksworkspace. Directory scoping wouldn't fix that when several TUIs share one directory (for example, a session switcher that drives one of several panes in the same repo).This adds an optional
clientfield to the request and event, and a--client <id>flag onopencodeandopencode attach. A TUI ignores a select event whoseclientis set to a different id. Ifclientis left out, every TUI still navigates, so existing callers keep working.The SDK changes come from re-running
packages/sdk/jsbuild.How did you verify your code works?
test/server/session-select.test.tschecks thatclientis published with the event. The existing select tests,httpapi-sdk.test.ts, and the codemode tests pass.--client aand--client b. Selecting withclient: "b"moved onlyb. Selecting withoutclientmoved both.Screenshots / recordings
Two TUIs attached to one server,
--client aon the left and--client bon the right. Selecting with"client":"b"moves only the right one. Selecting withoutclientmoves both, as before. (mp4)Checklist