Repository navigation
Conversation
github-actions
Bot
added
the
needs:compliance
3 tasks done
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
File paths and path:line references in assistant messages are now clickable links. Clicking opens the file in the review panel, scrolls to and highlights the referenced line/range, and opens a new tab per file. Directory-like and non-file inline code is deliberately not linkified.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #37891
Fixes the linkification failure modes reported in #51723 and #51872
Type of change
What does this PR do?
File paths in assistant messages were rendered as plain text, so users copy-pasted them instead of clicking. This makes them clickable:
a.java:355anda.java:355-360(colon form)packages/app/src/app.tsxx.tsat line 12" and Turkish "x.ts12. satırda"Clicking opens the file in the existing review panel, scrolls to and highlights the referenced line/range, one tab per file, keeping the changes tab intact.
To avoid dead-end clicks (#51723/#51872), only text whose last path segment has a file extension is linkified — directories (
map-component/objecttype/) and slash compounds (write/edit) are never turned into links, and absolute paths stay unlinked since they are ambiguous across machines.How did you verify your code works?
New parser unit tests (
file-reference.test.ts, 10 cases).bun testpasses insession-uiand in theappsession pages. Tested manually against a live dev server with multi-file chats in a Turkish locale.Screenshots / recordings
Will add a short recording.
Checklist