Repository navigation
fix(core): report inactivity eviction in interrupted work - #52587
thiago-carneiro wants to merge 1 commit into
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Supporting the reporting side — this would have made a real incident much easier to diagnose. On v2.0.22 a Surfacing the |
Issue for this PR
Closes #52597
Type of change
What does this PR do?
When idle location eviction interrupts a run, unsettled tool failures report the generic "Tool execution interrupted" — the reason never reaches the message. The run coordinator already records the interruption reason, so I thread it into the unsettled-tool failure message: an eviction-caused interruption now says "Tool execution interrupted: location idle eviction"; user- and shutdown-caused ones keep today's wording. Reporting only — the eviction policy and the hardcoded 60-minute deadline are #51343's questions.
The close-path surface (pending forms cancelled when the location closes, e.g. the "Interaction cancelled because the location shut down" case in #51647) keeps its current wording; I'll follow up with the close-path failure and the question content in that message.
How did you verify your code works?
bun run test(packages/core, full suite): 5272 passing, 0 failing, including two new cases insession-runner.test.ts— an eviction-caused interrupt asserts the eviction message, a user-caused one keeps the generic wordingbun turbo typecheck: 36/36 packages;bunx oxlint: 0 errorsbun run check: all tasks pass (ran in a container — my host's glibc 2.28 predates what the ast-grep binary needs; the same failure occurs on a pristine checkout, so it is environmental)To confirm the fix: park a session on
question, interrupt withreason: "inactivity"(or wait out the 60-minute idle deadline) — the tool failure now names the eviction.Screenshots / recordings
Not a UI change.
Checklist