Repository navigation
fix(core): terminate legacy MCP sessions on close - #52414
Merged
Merged
Conversation
Ichinose-Kazuki
pushed a commit
to Ichinose-Kazuki/opencode
that referenced
this pull request
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closing a remote MCP connection called
client.close(), which only aborts the transport's HTTP streams. The SDK sends the MCP sessionDELETEonly from the separateterminateSession(), so legacy Streamable HTTP sessions stayed alive on the server until its own expiry.The connection finalizer now terminates the session before closing:
Mcp-Session-Id; stdio and modern connections are unchanged.405is accepted; other failures and timeouts are logged as warnings and never preventclose(). It runs beforeclose()because theDELETEshares the transport's abort signal; a timed-out request is aborted by the followingclose().Unresponsive servers can add up to 1 second each to MCP teardown.
Verification
bun test test/mcp.test.ts test/mcp-oauth.test.tsandbun run checkpass.