Repository navigation
fix(core): rollback interrupted shell acquisition - #52386
Open
HermanGrondahl wants to merge 1 commit into
Open
HermanGrondahl wants to merge 1 commit into
HermanGrondahl wants to merge 1 commit into
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #48838.
Related to #33364.
Type of change
What does this PR do?
Shell.createstarts a process manager before returning the shell ID. If the caller is interrupted after registration but before that handoff, the manager can outlive its caller. Keep acquisition cancellable until handoff: interruption now stops the manager and removes any registered shell.Terminal finish and removal also serialize per shell ID, preventing a detached observer from publishing
shell.exitedaftershell.deletedor restoring removed retention state.How did you verify your code works?
Deterministic tests cover interruption after registration and before handoff, fast exit before handoff, pre-registration interruption, spawn failure, and removal during output settlement and suspended exit publication. The current unpatched
v2fails the pre-handoff regression.On current
v2with Bun 1.4.2: 123 pass, 19 platform skips, 0 fail, 628 expectations across the shell-tool, retention, and cross-spawn suites. Core typecheck, lint, andgit diff --checkpass. The pre-push hook also passed repository lint and typechecks.Screenshots / recordings
Not applicable; this is a non-UI change.
Checklist