Repository navigation
test(acp): drive ACP tests through the wire protocol - #52307
Merged
Merged
Conversation
2 of 6 tasks
Ichinose-Kazuki
pushed a commit
to Ichinose-Kazuki/opencode
that referenced
this pull request
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACP Effect port tracking: #35457 | Refs #37229 | Refs #41660 | Refs #49591 | Refs #51716
Why the change
The ACP tests called internals (
ACPService.make,streamTurn,replayMessages,syncEditedFiles) that the upcoming Effect port deletes, so this PR moves every behavioral test onto the ACP wire and lets the port rewrite internals without touching tests.Special things to note
session/update, permission andfs/write_text_filerequests,$/cancel_request) plus typed facts from the fake server. They do not pin exact internal request sequences.test.todoand fail today for the intended reason underbun test --todo:compactis missing from the advertised commands, usage covers only the last step, nativeedit/write/patchupdates have no locations, andopencode acpkeeps running after its private server dies. The last one needspgrep, so it is skipped on Windows.Change outline
One harness,
wire-fixture.ts, replacesservice-fixture.tsandsse-fixture.ts. The agent is built in one place (ACP.connect), which is the only line the port needs to change.Hooks return the events to stream, and the server gives each event its id and sequence number when sending it:
What each file covers now:
New characterization tests: