Repository navigation
fix(core): exclude commentary from generated session titles - #52006
Open
shanebishop1 wants to merge 3 commits into
Open
shanebishop1 wants to merge 3 commits into
shanebishop1 wants to merge 3 commits into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #51997
Type of change
What does this PR do?
Responses-style title responses can contain separate commentary and final-answer messages. The title collector joins both, saving titles like
We need title only....Exclude text blocks explicitly marked
phase: "commentary"in provider metadata after streaming, since the phase can arrive at block completion. Commentary-only responses use the existing fallback.How did you verify your code works?
Reproduced live with GPT-6 Luna. Added a regression through the production Responses parser and title service, covering phases arriving at block start or completion. All 17 title tests pass.
bun run check, formatting, andgit diff --checkpassed.Screenshots / recordings
N/A
Checklist