Skip to content

fix(app): keep mobile question controls visible - #51771

Open
ysm-dev wants to merge 1 commit into
anomalyco:v2from
ysm-dev:mobile-question-scroll
Open

ysm-dev wants to merge 1 commit into
anomalyco:v2from
ysm-dev:mobile-question-scroll

Conversation

@ysm-dev

@ysm-dev ysm-dev commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Issue for this PR

Closes #51770

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Long questions and option lists can push Next and Submit off mobile screens. The height calculation falls back to the full viewport when there is no sticky timeline header, and the question text sits outside the scrollable area.

Measure the available session-panel height on mobile as well as desktop. Scroll the question text and options together, keeping the header and footer visible. Add a long-question story and mobile regression coverage.

How did you verify your code works?

  • bun run check passed in the new worktree.
  • Question component suite: 8 passed across Chromium and WebKit. Covers 393 × 852, 393 × 640, landscape, answer retention, submission, and desktop shortcuts.
  • Agent-browser: captured before/after screenshots, scrolled to option 12, advanced, and submitted answers. Also checked the production build with a local fixture server, viewport resizing, and RTL.
  • Production cold-session benchmark: 206.9 ms before, 214.2 ms after, one sample each. Two unrelated draft-entry assertions already failed on the baseline.

To reproduce locally: bun run test:components session-question-dock.spec.ts from packages/app, or open the LongQuestionRequest Storybook story at a mobile viewport.

Screenshots / recordings

Agent-browser captures of the production question component in the session story, at 393 × 852.

Before: Next is below the screen After: content scrolls, Next stays visible
Before: question options overflow and Next is not visible After: scrollable question content with a visible Next button
Long question scrolled to its options, with Back and Submit visible A long question scrolled to its options with Back and Submit visible

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant