Skip to content

fix(tui): leave modified hyperlink clicks to the terminal - #51757

Open
gszep wants to merge 1 commit into
anomalyco:v2from
gszep:modified-link-click
Open

gszep wants to merge 1 commit into
anomalyco:v2from
gszep:modified-link-click

Conversation

@gszep

@gszep gszep commented Sep 28, 2026 •

Copy link
Copy Markdown

Issue for this PR

Closes #51756 (V2).

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Leave modified and non-primary clicks on TUI links to the terminal's native hyperlink handler. This avoids opening a second browser tab while preserving ordinary left-click opening.

How did you verify your code works?

The rendered Link regression covers plain, Ctrl-, Shift-, Alt- and right-clicks. The test, TUI typecheck and root bun run check pass.

Screenshots / recordings

Before/after terminal regression recording. It renders the production component with injected mouse events and counts browser-opener calls; it does not record native terminal/browser interaction. Download the .cast and replay with asciinema play.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

The following comment was made by an LLM, it may be inaccurate:

@gszep

gszep commented Sep 28, 2026

Copy link
Copy Markdown
Author

Thanks! The issue section already has Closes #51756. I re-triggered the check, but it runs the dev workflow, which only checks closingIssuesReferences (empty for this v2 target); the body-reference fallback is currently only on v2. Could a maintainer add the Development link to #51756, or bring that fallback to dev?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant