Skip to content

fix(core): retry failed session wakes - #51751

Open
jlongster wants to merge 1 commit into
v2from
retry-session-wakes
Open

jlongster wants to merge 1 commit into
v2from
retry-session-wakes

Conversation

@jlongster

Copy link
Copy Markdown
Collaborator

Issue for this PR

N/A

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

A prompt can be durably admitted and then stranded if its advisory session wake fails before the runner consumes the inbox item. The wake is fire-and-forget, so callers already received a successful admission while no later wake is guaranteed.

Retry one failed advisory wake when the durable inbox still has promotable work. The retry stays in the same execution busy period, so the execution claim and terminal lifecycle remain coherent. Explicit resumes and interruptions are not retried, and consumed work is not retried.

How did you verify your code works?

  • Added coordinator tests for transient success, persistent failure, and consumed-work behavior.
  • Added a SessionExecution test with a real pending inbox item.
  • bun test test/session-run-coordinator.test.ts
  • Focused SessionExecution and manual-compaction regression tests
  • bun run typecheck in packages/core
  • Repository pre-push lint and full typecheck passed.
  • Full Core run: 5,511 passed, 41 skipped; 7 existing shell-scan parity failures remain unrelated.

Screenshots / recordings

Not applicable.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant