Repository navigation
Conversation
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
|
The following comment was made by an LLM, it may be inaccurate: |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
6b274e8 to
8e2ac2f
Compare
8e2ac2f to
0fa120d
Compare
|
One policy note: the 1h bound on unanswered questions preserves the exact failure #51343 reports. I measured a pending question waiting 5462.9s (~91 min) before the idle eviction killed it — a human answering at 1h15 would still lose the run. #50499's approach (renew the deadline while a form/permission is pending, explicit Stop still interrupts) also covers the fairness case you're solving — it protects co-owners of a directory where another session waits (there's a test for exactly that). Any appetite for dropping the bound for human waits and keeping your per-session progress signal for everything else? |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
Issue for this PR
Fixes #51343 (progressing Sessions and owned shell/subagent work). Related: #48691, #44471.
Type of change
What does this PR do?
Release inactive Sessions without interrupting other progressing Sessions or killing their foreground/background work.
Special things to note
Change outline
How did you verify your code works?
/bin/bash3.2.bun run checkpassed: 36/36 typecheck tasks, lint warnings but no errors.git diff --checkpassed.Screenshots / recordings
Earlier isolated TUI demonstration: simulated streams drive 3 same-directory Sessions; C's unanswered question expires while A and B continue. The inactivity timeout was temporarily 5 seconds with a 250 ms sweep; neither the override nor simulation harness is included in this PR.
session-inactivity-clean.mp4
Checklist