Repository navigation
refactor(util): share a browser opener across cli, tui, and core - #51412
Merged
Merged
Conversation
Move browser launching into @opencode/util/open so the CLI and TUI stop importing open directly. openUrl only accepts http and https targets and openPath handles file manager requests. The core MCP OAuth provider now applies the same check before handing an authorization URL to a client. Bump open to 11 and let util own the dependency, with a root override so the tree resolves to a single copy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Seven places across
cliandtuiimportedopendirectly to launch a browser or file manager, each with its own error handling and two of them lazily importing the module by hand. This consolidates them behind a small@opencode/util/openmodule and makesutilthe single owner of the dependency.Changes
@opencode/util/open—openUrl(input)parses the target and only launcheshttp:/https:URLs, passing the normalizedhreftoopen.openPath(path)covers the working-directory "Open folder" action, which is a filesystem path rather than a URL.cli/src/ui/prompt.ts,tui/src/ui/link.tsx,tui/src/routes/session/form.tsx,tui/src/component/dialog-integration.tsx,tui/src/mini/footer.form.tsx,tui/src/app.tsxnow useopenUrl;tui/src/ui/working-directory-actions.tsxusesopenPath. Existing error handling at each site is unchanged.redirectToAuthorizationapplies the same http/https check before handing an authorization URL to a client, so every client of the server gets consistent behaviour without reimplementing it.openbumped10.1.2→11.0.4, moved fromcli/tuiintoutil. A rootoverridesentry lifts the transitive copies fromstorybookandlighthouseso the lockfile resolves to exactly one version.open@11also handles the missingimport.meta.urlcase the bundled binary hits.Testing
packages/util/src/open.test.tscovers the rejection paths foropenUrl(unparseable input,file:,javascript:, custom schemes, UNC paths).packages/core/test/mcp-oauth.test.tsadds a case where the authorization server advertises a non-http endpoint and asserts the flow fails with a clear error naming the server.bun run checkgreen;bun typecheckclean inutil,cli,tui,core.