Skip to content

fix(gemini): switch thinking default logic - #50841

Merged
rekram1-node merged 3 commits into
anomalyco:devfrom
markmcd:gemini-3-thinking-default
Sep 23, 2026
Merged

rekram1-node merged 3 commits into
anomalyco:devfrom
markmcd:gemini-3-thinking-default

Conversation

@markmcd

@markmcd markmcd commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

Type of change

  • Refactor / code improvement

What does this PR do?

Switch logic for Gemini thinking such that Gemini 3 is the default, and older models are exceptional.

How did you verify your code works?

Updated & existing unit tests all pass.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Sep 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Sep 23, 2026
@github-actions github-actions Bot closed this Sep 23, 2026
@rekram1-node rekram1-node reopened this Sep 23, 2026
Skip the default thinkingLevel / OpenRouter reasoning effort when a model's variants are token-budget shaped, so a budget variant can never be merged with an effort. Also limit Gemma 4 variants to the minimal/high levels the Gemini API accepts.
@github-actions github-actions Bot added the needs:compliance This means the issue will auto-close after 2 hours. label Sep 23, 2026
Unlisted Gemini models are assumed to use efforts; only explicitly listed older models take the token path.
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed because it was not updated to meet our contributing guidelines within the 2-hour window.

Feel free to open a new pull request that follows our guidelines.

@github-actions github-actions Bot removed the needs:compliance This means the issue will auto-close after 2 hours. label Sep 23, 2026
@github-actions github-actions Bot closed this Sep 23, 2026
@rekram1-node rekram1-node reopened this Sep 23, 2026
@rekram1-node
rekram1-node merged commit 610df0b into anomalyco:dev Sep 23, 2026
6 of 8 checks passed
rldona pushed a commit to rldona/FlupCode that referenced this pull request Sep 24, 2026
Jovan1666 pushed a commit to Jovan1666/opencode that referenced this pull request Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants