Repository navigation
fix(core): honor model tool capabilities - #50243
Closed
andreivince wants to merge 1 commit into
Closed
andreivince wants to merge 1 commit into
andreivince wants to merge 1 commit into
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Withdrawn because #35432 is already assigned. The tested patch remains available on this branch.
Issue for this PR
Closes #35432
This PR targets
v2as required by CONTRIBUTING.md. The default-branch issue check still lacks the body-reference fallback merged in #43964, so itsneeds:issuewarning does not recognize the issue above.Type of change
What does this PR do?
V2 still sends tool definitions when a model declares
capabilities.tools: false, causing providers to reject requests for models without tool support.Use an empty tool snapshot before request hooks and omit tool choice for these models. Capable models retain their tools, hook renames, and execution behavior. Existing conversation history is preserved.
How did you verify your code works?
The workspace check hits 10 existing CLI/TUI signal-handler type errors, also reproduced on unchanged
58fcad77a. Testing used Bun 1.4.2 and Bash 5.3 on macOS arm64.Screenshots / recordings
Not applicable.
Checklist