Repository navigation
fix(core): prefer Windows .cmd over nvm .ps1 shims when spawning npm/npx - #50050
Open
cestercian wants to merge 1 commit into
Open
cestercian wants to merge 1 commit into
cestercian wants to merge 1 commit into
Conversation
Windows nvm ships npm.ps1 next to npm.cmd. Resolving the PowerShell shim lets ShellExecute open it in Notepad. Drop .PS1 from PATHEXT and rewrite spawn targets to a sibling .cmd/.exe/.bat. Fixes anomalyco#50040
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #50040
Type of change
What does this PR do?
On Windows, nvm ships
npm.ps1/npx.ps1next to.cmd. Bun can resolve the.ps1and ShellExecute it as a document (Notepad). Drop.PS1fromPATHEXTfor resolution and rewrite spawn targets to a sibling.cmd/.exe/.batin the shared spawn paths (TUI + webchat + MCP stdionpx).How did you verify your code works?
packages/core/test/util/which.test.tspackages/opencode/test/util/process.test.ts(Windows spawn cases skipped on Linux)bun typecheckinpackages/coreandpackages/opencodeChecklist