Repository navigation
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #49861 (re-report of #35917, which was auto-closed after 60 days of inactivity)
Type of change
What does this PR do?
The SSE
/eventhandler filters the stream withevent.location?.directory === instance.directory. Worktree sessions live in a different directory than the main checkout, so every event from worktree activity fails that check and is dropped — subscribers receive nothing for worktree sessions (#35917/#49861).This removes the directory equality check and keeps the
workspaceIDcheck, so clients still only receive events for their own workspace (or workspace-global events whereworkspaceIDis undefined).Supersedes #35913 — same change, rebased onto current dev; that PR was closed by the automated cleanup bot for age, not on merit.
How did you verify your code works?
Ran the server from source (
bun packages/opencode/src/index.ts serve) against a git repo with a worktree, on unpatched dev and on this branch:/event?directory=<main-checkout>POST /session?directory=<worktree-dir>(response confirms"directory": "<worktree-dir>")5f9d9187c)server.connectedonly —session.createddroppedserver.connected+session.createdScreenshots / recordings
Server-side change; table above.
Checklist