Repository navigation
fix(tui): keep btw dialog in plugin context - #49828
Closed
opencode-agent[bot] wants to merge 1 commit into
Closed
opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
Capture the markdown renderer from the app slot before opening the sibling dialog, so rendering a generated /btw answer no longer calls usePlugin outside PluginProvider. Add a fixture-driven regression test for the complete slash-command flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49777
Summary
/btwapp slot is still underPluginProviderusePlugin()outside the provider boundary/btwsubmission through rendered answerTests
bun test test/feature-plugins/btw.test.tsx --timeout 30000bun test test/plugin-markdown.test.tsx test/app-lifecycle.test.tsx --timeout 30000bun typecheckRequested by: @rekram1-node (Aiden Cline via Slack)