Repository navigation
Conversation
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found one potentially related PR: Related PR:
However, this is a different fix targeting a different scope (opencode vs core) and the current PR (47357) appears to be the primary fix for issue #46881 about handling standalone signed-empty reasoning turns. No other direct duplicates found. |
83080f4 to
3079fb4
Compare
|
@rekram1-node This is now based on Standalone signature-only messages are omitted, but signatures alongside text or a tool call are preserved. The 24 replay tests and the package typecheck pass. Could you review this for #46881 and approve the fork CI when you have a chance? |
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
Issue for this PR
Closes #46881
Type of change
What does this PR do?
V2 keeps a reasoning message in model history even when it contains only a provider signature. These empty messages accumulate and get sent again on later requests.
Drop the standalone empty message, but keep its signature when the same message also contains text or a tool call. This changes history replay only. #45839 handles the separate legacy replay path.
How did you verify your code works?
bun test test/session-runner-message.test.tsinpackages/core: 24 passed. Covers standalone signatures and signatures paired with text or a tool call.bun typecheckinpackages/core: passed.v2; it is not fully green locally.Screenshots / recordings
Not applicable.
Checklist