Repository navigation
fix(desktop): harden packaged Electron - #46632
Closed
opencode-agent[bot] wants to merge 1 commit into
Closed
opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
opencode-agent
Bot
requested review from
Brendonovich and
Hona
as code owners
September 1, 2026 17:02
Contributor
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file://privileges because the renderer usesoc://Why
The packaged app kept Electron's permissive default fuses. This left the signed executable usable as a Node runtime, accepted runtime injection and inspector flags, and allowed substituted application code outside the ASAR. Electron recommends disabling unused powerful features and combining ASAR integrity with ASAR-only loading.
Checks
GOMAXPROCS=1 GOMEMLIMIT=1500MiB bun typecheck(packages/desktop)bun test electron-builder.config.test.ts(12 pass)bun x prettier --check electron-builder.config.ts electron-builder.config.test.tsgit diff --checkbun test: 90 pass; host Node 18 lacksnode:sqlitefordrafts.test.tsRequested by: @Hona (Hona via Slack)