Skip to content

fix(tool): simplify the glob path parameter description - #45120

Open
rareboe wants to merge 1 commit into
anomalyco:devfrom
rareboe:fix/44489-glob-path-description
Open

rareboe wants to merge 1 commit into
anomalyco:devfrom
rareboe:fix/44489-glob-path-description

Conversation

@rareboe

@rareboe rareboe commented Aug 26, 2026 •

Copy link
Copy Markdown

Issue for this PR

Closes #44489

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

Shortens the glob path description, dropping the IMPORTANT: ... DO NOT enter "undefined" or "null" block that destabilised Qwen3-Coder via llama.cpp (#44489). The wording now matches grep and the v2 glob tool. No behaviour change.

How did you verify your code works?

The parameters snapshot shows only this string changed. bun test test/tool passes.

Screenshots / recordings

N/A

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

The glob `path` description was the only tool parameter in the repo carrying an
`IMPORTANT: ... DO NOT enter "undefined" or "null"` block. Grammar-constrained
local backends can destabilise on it: anomalyco#44489 reports Qwen3-Coder through
llama.cpp emitting repeated text, malformed tool calls and degenerate `?`
arguments for glob, all of which stop once the description is simplified.

Match the wording already used by the neighbouring grep tool and by the v2 glob
tool in packages/core. The "must be a valid directory path" hint is kept because
the tool really does throw when the path is not a directory.
@rareboe
rareboe force-pushed the fix/44489-glob-path-description branch from 93bf9e7 to 2787f03 Compare September 29, 2026 15:33

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

glob.path description can trigger unstable tool-calling behavior with llama.cpp/Qwen3-Coder

1 participant