Repository navigation
Conversation
b5c6c83 to
0dc9bc7
Compare
Solid approach overall: a single pinned manifest (sha256 for every asset), hash verification on both the Nix-provided and network-fetched paths, and a clean dev-vs-build split through the committed stub. Points to consider:
No blocking issues found. |
0dc9bc7 to
32a615b
Compare
|
These have been addressed, minus:
This I plan to do in a later PR.
This isn't a worthwhile thing to log / display to the user. |
The e2e grammar sweep caught three grammars whose pinned query files reference node names missing from the pinned grammar wasm: - diff: wasm 0.1.0 → 0.2.0 (query already pinned at 0.2.0) - make: query nvim-treesitter@074aa442 → tree-sitter-make 1.1.1 (wasm 1.1.1) - scala: query nvim-treesitter@074aa442 → tree-sitter-scala 0.24.0 (wasm 0.24.0)
32a615b to
655f774
Compare
|
Automated PR Cleanup Thank you for contributing to opencode. Due to the high volume of PRs from users and AI agents, we periodically close older PRs using automated criteria so maintainers can focus review time on the most active and community-supported contributions. This PR was closed because it matched the following cleanup criteria:
PRs created within the last month are not affected by this cleanup. If you believe this PR was closed incorrectly, or if you are still actively working on it, please leave a comment explaining why it should be reopened. A maintainer can review and reopen it if appropriate. Thanks again for taking the time to contribute. |
|
@thdxr @rekram1-node Could you please assign this for review? Would be great if we weren't all calling out to GitHub (which doesn't have the greatest uptime record) for syntax highlighting. |
Issue for this PR
I guess somewhat related to the offline / air-gap features: #18492
Type of change
What does this PR do?
Takes the
tree-sittergrammars and bundles them in at build time rather than calling out to the internet at runtime when a file is written. Also resolved an issue with a new grammar fromunpkg.comnot loading for some unknown reason, but worked fine once it had been bundled in by this mechanism.Also changes the URLs from
masterto a fixed tag or latest Git commit hash for thenvim-treesitterrepo for better reproducibility / change-control.How did you verify your code works?
Deployed the Nix flake and verified the LLM writes to a file whilst the correct syntax highlighting is displayed.
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.