Skip to content

fix(copilot): honor advertised model endpoints #34958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rekram1-node merged 2 commits into from
Jul 2, 2026
Merged

fix(copilot): honor advertised model endpoints #34958

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac4d208
fix(copilot): honor advertised model endpoints
rekram1-node Jul 2, 2026
43fa6c7
refactor(copilot): inline endpoint selection checks
rekram1-node Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor(copilot): inline endpoint selection checks
  • Loading branch information
@rekram1-node
rekram1-node committed Jul 2, 2026
commit 43fa6c796cac9c6ecab4dc37160e9913d257354f
34 changes: 9 additions & 25 deletions packages/core/src/plugin/provider/github-copilot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,25 +3,6 @@ import { ModelV2 } from "../../model"
import { ProviderV2 } from "../../provider"
import type { PluginContext } from "@opencode-ai/plugin/v2/effect"

const CopilotEndpoint = {
chat: "chat",
responses: "responses",
} as const

function endpointFromOptions(options: Record<string, unknown>) {
if (options.endpoint === CopilotEndpoint.responses) return CopilotEndpoint.responses
if (options.endpoint === CopilotEndpoint.chat) return CopilotEndpoint.chat
return undefined
}

function shouldUseResponses(modelID: string) {
// Copilot supports Responses for GPT-5 class models, except mini variants
// which still need the chat-completions endpoint.
const match = /^gpt-(\d+)/.exec(modelID)
if (!match) return false
return Number(match[1]) >= 5 && !modelID.startsWith("gpt-5-mini")
}

export const GithubCopilotPlugin = {
id: "github-copilot",
effect: Effect.fn(function* (ctx: PluginContext) {
Expand Down Expand Up @@ -50,18 +31,21 @@ export const GithubCopilotPlugin = {
evt.language = evt.sdk.languageModel(evt.model.api.id)
return
}
const endpoint = endpointFromOptions(evt.options)
if (endpoint === CopilotEndpoint.responses && evt.sdk.responses) {
if (evt.options.endpoint === "responses" && evt.sdk.responses) {
evt.language = evt.sdk.responses(evt.model.api.id)
return
}
if (endpoint === CopilotEndpoint.chat && evt.sdk.chat) {
if (evt.options.endpoint === "chat" && evt.sdk.chat) {
evt.language = evt.sdk.chat(evt.model.api.id)
return
}
evt.language = shouldUseResponses(evt.model.api.id) && evt.sdk.responses
? evt.sdk.responses(evt.model.api.id)
: evt.sdk.chat(evt.model.api.id)
const match = /^gpt-(\d+)/.exec(evt.model.api.id)
// Copilot supports Responses for GPT-5 class models, except mini variants
// which still need the chat-completions endpoint.
evt.language =
match && Number(match[1]) >= 5 && !evt.model.api.id.startsWith("gpt-5-mini") && evt.sdk.responses
? evt.sdk.responses(evt.model.api.id)
: evt.sdk.chat(evt.model.api.id)
}),
)
}),
Expand Down
14 changes: 4 additions & 10 deletions packages/opencode/src/provider/provider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,6 @@ function selectBedrockMantleLanguageModel(sdk: BundledSDK, modelID: string) {
return sdk.responses?.(modelID) ?? sdk.languageModel(modelID)
}

function copilotEndpoint(model?: Model) {
if (!model || !("endpoint" in model.api)) return undefined
if (model.api.endpoint === "responses") return "responses"
if (model.api.endpoint === "chat") return "chat"
return undefined
}

function custom(dep: CustomDep): Record<string, CustomLoader> {
return {
anthropic: () =>
Expand Down Expand Up @@ -227,9 +220,10 @@ function custom(dep: CustomDep): Record<string, CustomLoader> {
autoload: false,
async getModel(sdk: any, modelID: string, _options?: Record<string, any>, model?: Model) {
if (sdk.responses === undefined && sdk.chat === undefined) return sdk.languageModel(modelID)
const endpoint = copilotEndpoint(model)
if (endpoint === "responses" && sdk.responses) return sdk.responses(modelID)
if (endpoint === "chat" && sdk.chat) return sdk.chat(modelID)
if (model && "endpoint" in model.api) {
if (model.api.endpoint === "responses" && sdk.responses) return sdk.responses(modelID)
if (model.api.endpoint === "chat" && sdk.chat) return sdk.chat(modelID)
}
const match = /^gpt-(\d+)/.exec(modelID)
if (match && Number(match[1]) >= 5 && !modelID.startsWith("gpt-5-mini")) return sdk.responses(modelID)
return sdk.chat(modelID)
Expand Down
Loading