Skip to content

fix(app): disable empty server chevron #34292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brendonovich merged 5 commits into from
Jun 29, 2026
Merged

fix(app): disable empty server chevron #34292

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
067196e
fix(app): hide empty server chevron
neriousy Jun 28, 2026
946999d
disable rather than hide
neriousy Jun 28, 2026
83209a7
remove props passing
neriousy Jun 28, 2026
3138feb
render chevron on disabled servers
neriousy Jun 28, 2026
df81764
Merge branch 'dev' into hide-empty-chevron
neriousy Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(app): hide empty server chevron
  • Loading branch information
@neriousy
neriousy committed Jun 28, 2026
commit 067196e41de75c2ed91b0546b357f3a3aaf39927
10 changes: 7 additions & 3 deletions packages/app/src/pages/home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,13 +568,16 @@ function HomeProjectColumn(props: {
const key = ServerConnection.key(item)
const healthy = () => !!global.servers.health[key]?.healthy
const serverCtx = global.ensureServerCtx(item)
const projects = () => serverCtx.projects.list()
const hasProjects = () => projects().length > 0
const collapsed = () => !!state().collapsed[key]
return (
<div class="flex max-h-[min(572px,calc(100vh_-_300px))] min-w-0 flex-col gap-1 overflow-y-auto [scrollbar-width:none] [&::-webkit-scrollbar]:hidden">
<HomeServerRow
server={item}
selected={props.selected.server === key && !props.selected.directory}
healthy={healthy()}
hasProjects={hasProjects()}
collapsed={collapsed()}
health={global.servers.health[key]}
controller={controller}
Expand All @@ -584,9 +587,9 @@ function HomeProjectColumn(props: {
toggleCollapsed={() => setState("collapsed", key, !state().collapsed[key])}
language={props.language}
/>
<Show when={healthy() && !collapsed()}>
<Show when={healthy() && hasProjects() && !collapsed()}>
<div class="mx-3 h-px bg-v2-border-border-base" />
<HomeProjectList {...props} server={item} projects={serverCtx.projects.list()} />
<HomeProjectList {...props} server={item} projects={projects()} />
</Show>
</div>
)
Expand Down Expand Up @@ -635,6 +638,7 @@ function HomeServerRow(props: {
server: ServerConnection.Any
selected: boolean
healthy: boolean
hasProjects: boolean
collapsed: boolean
health: ServerHealth | undefined
controller: ReturnType<typeof useServerManagementController>
Expand All @@ -654,7 +658,7 @@ function HomeServerRow(props: {
disabled={!props.healthy}
onClick={() => props.focusServer(props.server)}
>
<Show when={props.healthy}>
<Show when={props.healthy && props.hasProjects}>
<span
data-action="home-server-collapse"
class="inline-flex -ml-0.5 -mr-1.5 size-5 shrink-0 items-center justify-center rounded-[4px] text-v2-icon-icon-muted hover:bg-v2-overlay-simple-overlay-hover"
Expand Down
Loading