Skip to content

fix(app): scope session page errors #34254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Brendonovich merged 12 commits into from
Jul 1, 2026
Merged

fix(app): scope session page errors #34254

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
4edaa41
fix(app): scope session page errors
Brendonovich Jun 27, 2026
22c587c
fix(app): gate session error boundary
Brendonovich Jun 27, 2026
4524101
fix(app): show unknown session tabs
Brendonovich Jun 27, 2026
5d20ebe
Merge remote-tracking branch 'origin/dev' into session-error-boundary
Brendonovich Jun 30, 2026
9a88317
fix(app): contain target session errors
Brendonovich Jun 30, 2026
bc1513d
fix(app): simplify session not found fallback
Brendonovich Jun 30, 2026
9e167fa
fix(app): improve session not found fallback
Brendonovich Jun 30, 2026
9d8a9c3
fix(app): soften missing session id styling
Brendonovich Jun 30, 2026
e00de49
fix(app): show server on missing session fallback
Brendonovich Jun 30, 2026
edd65fc
fix(app): refine missing session details
Brendonovich Jun 30, 2026
733c45c
change text size
Brendonovich Jun 30, 2026
bec0557
Merge remote-tracking branch 'origin/dev' into session-error-boundary
Brendonovich Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(app): refine missing session details
  • Loading branch information
@Brendonovich
Brendonovich committed Jun 30, 2026
commit edd65fcbbaf40a5b1aab4aeb4223198c06fc7a4d
8 changes: 4 additions & 4 deletions packages/app/src/pages/session.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,11 @@ function SessionErrorFallback(props: { error: unknown; sessionID?: string; serve
</div>
<Show when={props.sessionID}>
{(sessionID) => (
<div class="max-w-full flex flex-col items-center gap-1 text-11-regular text-text-weak">
<code class="max-w-full rounded-[4px] px-1 py-0.5 font-mono text-[10px] font-medium leading-4 text-text break-all bg-[color-mix(in_oklch,var(--v2-text-text-base)_8%,transparent)]">
<div class="max-w-full flex flex-col items-center gap-1">
<div class="max-w-full text-11-regular text-text-faint break-all">
{displayServer()}
</code>
<code class="max-w-full rounded-[4px] px-1 py-0.5 font-mono text-[10px] font-medium leading-4 text-text break-all bg-[color-mix(in_oklch,var(--v2-text-text-base)_8%,transparent)]">
</div>
<code class="max-w-full rounded-[4px] px-1 py-0.5 font-mono text-[10px] font-medium leading-4 text-text-base break-all bg-[color-mix(in_oklch,var(--v2-text-text-base)_8%,transparent)]">
{sessionID()}
</code>
</div>
Expand Down
Loading