Skip to content

feat(sdk): restore session runtime operations #33777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kitlangton merged 9 commits into from
Jun 25, 2026
Merged

feat(sdk): restore session runtime operations #33777

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eee2eb1
feat(sdk): restore session runtime operations
kitlangton Jun 25, 2026
2b6e4ad
test(opencode): cover session runtime routes
kitlangton Jun 25, 2026
8cac327
refactor(sdk): keep session events durable
kitlangton Jun 25, 2026
93aaa80
fix(core): drop failed turn continuation metadata
kitlangton Jun 25, 2026
9305264
refactor: simplify session runtime contracts
kitlangton Jun 25, 2026
5b289b3
chore(client): regenerate session types
kitlangton Jun 25, 2026
6a2396b
fix(schema): preserve event codec requirements
kitlangton Jun 25, 2026
d8a5a47
refactor(sdk): simplify embedded HTTP bridge
kitlangton Jun 25, 2026
0044d60
docs(llm): remove unrelated architecture agenda
kitlangton Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: simplify session runtime contracts
  • Loading branch information
@kitlangton
kitlangton committed Jun 25, 2026
commit 9305264bf6b5df810ad20b0549721ff24f885b80
7 changes: 4 additions & 3 deletions packages/core/src/session/runner/to-llm-message.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ const toolResult = (tool: SessionMessage.AssistantTool, providerMetadata: Provid
const assistant = (message: SessionMessage.Assistant, model: Model) => {
const sameModel =
String(message.model.providerID) === String(model.provider) && String(message.model.id) === String(model.id)
const reuseProviderMetadata = sameModel && message.finish !== "error"
const reuseProviderMetadata = sameModel && message.error === undefined
const content = message.content.flatMap((item): ContentPart[] => {
if (item.type === "text") return [{ type: "text", text: item.text }]
if (item.type === "reasoning")
Expand All @@ -86,11 +86,12 @@ const assistant = (message: SessionMessage.Assistant, model: Model) => {
? [{ type: "text", text: item.text }]
: []
const call = toolCall(item, reuseProviderMetadata ? item.provider?.metadata : undefined)
if (item.provider?.executed !== true) return [call]
const result = toolResult(
item,
reuseProviderMetadata ? (item.provider?.resultMetadata ?? item.provider?.metadata) : undefined,
reuseProviderMetadata ? (item.provider.resultMetadata ?? item.provider.metadata) : undefined,
)
return item.provider?.executed === true && result ? [call, result] : [call]
return result ? [call, result] : [call]
})
const meaningful = content.filter((part) => {
if (part.type === "text") return part.text !== ""
Expand Down
5 changes: 1 addition & 4 deletions packages/protocol/src/groups/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ const SessionsQueryFields = {
search: Schema.optional(Schema.String),
}

const SessionEventSchema: Schema.Codec<typeof SessionEvent.Durable.Type, typeof SessionEvent.Durable.Encoded> =
Schema.make(SessionEvent.Durable.ast)

const SessionsDirectoryQuery = Schema.Struct({
...SessionsQueryFields,
directory: AbsolutePath,
Expand Down Expand Up @@ -282,7 +279,7 @@ export const makeSessionGroup = <I extends HttpApiMiddleware.AnyId, S>(sessionLo
query: {
after: Schema.NumberFromString.pipe(Schema.decodeTo(NonNegativeInt), Schema.optional),
},
success: HttpApiSchema.StreamSse({ data: SessionEventSchema }),
success: HttpApiSchema.StreamSse({ data: SessionEvent.Durable }),
error: SessionNotFoundError,
})
.middleware(sessionLocationMiddleware)
Expand Down