Skip to content
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor(protocol): define current event surface
  • Loading branch information
kitlangton committed Jun 25, 2026
commit 6ad5ce39beb88ababd7d429e45769ea61b2795d2
2 changes: 1 addition & 1 deletion packages/protocol/src/groups/event.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@ const make = (definitions: ReadonlyArray<Definition>) => {

export const makeEventGroup = (definitions: ReadonlyArray<Definition>) => make(definitions).group

const event = make(EventManifest.ServerDefinitions)
const event = make(EventManifest.CurrentServerDefinitions)
export const EventGroup = event.group
export type Event = typeof event.schema.Type
33 changes: 33 additions & 0 deletions packages/protocol/test/event-boundary.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { expect, test } from "bun:test"
import { EventManifest } from "@opencode-ai/schema/event-manifest"
import { SessionV1 } from "@opencode-ai/schema/session-v1"

test("current Protocol events exclude V1-only session events", () => {
const current = new Set<string>(EventManifest.CurrentServerDefinitions.map((definition) => definition.type))
const v1Only = SessionV1.Event.Definitions.filter((definition) => definition.durable !== undefined).map(
(definition) => definition.type,
)

expect(v1Only).toEqual([
"session.created",
"session.updated",
"session.deleted",
"message.updated",
"message.removed",
"message.part.updated",
"message.part.removed",
])
expect(v1Only.filter((type) => current.has(type))).toEqual([])
expect(current.has("session.next.prompted")).toBe(true)
expect(current.has("permission.v2.asked")).toBe(true)
expect(current.has("question.v2.asked")).toBe(true)
expect(current.has("command.executed")).toBe(false)
})

test("compatibility server inventory retains V1 events", () => {
const compatibility = new Set(EventManifest.ServerDefinitions.map((definition) => definition.type))

expect(compatibility.has("session.created")).toBe(true)
expect(compatibility.has("message.updated")).toBe(true)
expect(compatibility.has("message.part.updated")).toBe(true)
})
24 changes: 19 additions & 5 deletions packages/schema/src/event-manifest.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,21 @@ import { WorktreeEvent } from "./worktree-event"
const sessionV1DurableDefinitions = SessionV1.Event.Definitions.filter((definition) => definition.durable !== undefined)
const sessionV1LiveDefinitions = SessionV1.Event.Definitions.filter((definition) => definition.durable === undefined)

const coreDefinitions = Event.inventory(...sessionV1DurableDefinitions, ...SessionEvent.Definitions)
const currentCoreDefinitions = Event.inventory(...SessionEvent.Definitions)
const compatibilityCoreDefinitions = Event.inventory(...sessionV1DurableDefinitions, ...currentCoreDefinitions)

const foundationDefinitions = Event.inventory(
const currentFoundationDefinitions = Event.inventory(
...ModelsDev.Event.Definitions,
...Integration.Event.Definitions,
...Catalog.Event.Definitions,
...coreDefinitions,
...currentCoreDefinitions,
)

const compatibilityFoundationDefinitions = Event.inventory(
...ModelsDev.Event.Definitions,
...Integration.Event.Definitions,
...Catalog.Event.Definitions,
...compatibilityCoreDefinitions,
)

const featureDefinitions = Event.inventory(
Expand All @@ -54,14 +62,20 @@ const featureDefinitions = Event.inventory(
...Question.Event.Definitions,
)

export const CurrentServerDefinitions = Event.inventory(
...currentFoundationDefinitions,
...featureDefinitions,
...SessionTodo.Event.Definitions,
)

export const ServerDefinitions = Event.inventory(
...foundationDefinitions,
...compatibilityFoundationDefinitions,
...featureDefinitions,
...SessionTodo.Event.Definitions,
)

export const Definitions = Event.inventory(
...foundationDefinitions,
...compatibilityFoundationDefinitions,
...sessionV1LiveDefinitions,
...InstallationEvent.Definitions,
...featureDefinitions,
Expand Down