Skip to content

fix(desktop): disable hidden agent cycling #31207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hona merged 2 commits into from
Jun 7, 2026
Merged

fix(desktop): disable hidden agent cycling #31207

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9dace4d
fix(desktop): disable hidden agent cycling
Hona Jun 7, 2026
e91f08b
refactor(desktop): inline agent cycle guard
Hona Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(desktop): disable hidden agent cycling
  • Loading branch information
@Hona
Hona committed Jun 7, 2026
commit 9dace4dfc9106208ed64a3bd28dc8cf9a91573f8
16 changes: 16 additions & 0 deletions packages/app/src/pages/session/agent-cycle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { describe, expect, test } from "bun:test"
import { agentCycleDisabled } from "./agent-cycle"

describe("agentCycleDisabled", () => {
test("disables agent cycling when custom agents are hidden in desktop v2", () => {
expect(agentCycleDisabled(true, false)).toBe(true)
})

test("allows agent cycling when custom agents are shown", () => {
expect(agentCycleDisabled(true, true)).toBe(false)
})

test("allows agent cycling outside desktop v2", () => {
expect(agentCycleDisabled(false, false)).toBe(false)
})
})
2 changes: 2 additions & 0 deletions packages/app/src/pages/session/agent-cycle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export const agentCycleDisabled = (desktopV2: boolean, showCustomAgents: boolean) =>
desktopV2 && !showCustomAgents
3 changes: 3 additions & 0 deletions packages/app/src/pages/session/use-session-commands.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { createSessionTabs } from "@/pages/session/helpers"
import { extractPromptFromParts } from "@/utils/prompt"
import { UserMessage } from "@opencode-ai/sdk/v2"
import { useSessionLayout } from "@/pages/session/session-layout"
import { agentCycleDisabled } from "./agent-cycle"

export type SessionCommandContext = {
navigateMessageByOffset: (offset: number) => void
Expand Down Expand Up @@ -547,13 +548,15 @@ export const useSessionCommands = (actions: SessionCommandContext) => {
description: language.t("command.agent.cycle.description"),
keybind: "mod+.",
slash: "agent",
disabled: agentCycleDisabled(desktopV2(), settings.general.showCustomAgents()),
onSelect: () => local.agent.move(1),
}),
agentCommand({
id: "agent.cycle.reverse",
title: language.t("command.agent.cycle.reverse"),
description: language.t("command.agent.cycle.reverse.description"),
keybind: "shift+mod+.",
disabled: agentCycleDisabled(desktopV2(), settings.general.showCustomAgents()),
onSelect: () => local.agent.move(-1),
}),
]
Expand Down
Loading